Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract user id from token to url #68

Merged
merged 17 commits into from
Jun 29, 2020
Merged

Extract user id from token to url #68

merged 17 commits into from
Jun 29, 2020

Conversation

Serhii1011010
Copy link

@Serhii1011010 Serhii1011010 commented Jun 26, 2020 •
edited
Loading

Description

Fixes #69

Was blocked by RedHatInsights/insights-results-aggregator#905

Should be deployed together with RedHatInsights/insights-results-aggregator#905

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor (refactoring code, removing useless files)
  • Unit tests (no changes in the code)

Testing steps

make before_commit

@Serhii1011010 Serhii1011010 marked this pull request as ready for review June 29, 2020 12:33
@Serhii1011010 Serhii1011010 changed the title [WIP] Extract user id from token to url Extract user id from token to url Jun 29, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #68 into master will decrease coverage by 0.22%.
The diff coverage is 72.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   42.17%   41.95%   -0.23%     
==========================================
  Files          12       12              
  Lines         799      882      +83     
==========================================
+ Hits          337      370      +33     
- Misses        422      469      +47     
- Partials       40       43       +3
Impacted Files Coverage Δ
server/server.go 44.70% <51.61%> (-5.50%) ⬇️
content/parsing.go 74.57% <75.00%> (-1.29%) ⬇️
content/content.go 66.66% <100.00%> (+0.53%) ⬆️
server/endpoints.go 100.00% <100.00%> (ø)
server/router_utils.go 0.00% <0.00%> (-6.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4b367...24b88e9. Read the comment docs.

joselsegura
joselsegura approved these changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@joselsegura joselsegura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, wonderful job

@quarckster quarckster merged commit efd2001 into RedHatInsights:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joselsegura joselsegura joselsegura approved these changes

@quarckster quarckster quarckster approved these changes

@Bee-lee Bee-lee Awaiting requested review from Bee-lee

@bond95 bond95 Awaiting requested review from bond95

@natiiix natiiix Awaiting requested review from natiiix

@tisnik tisnik Awaiting requested review from tisnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract user id from token to url
4 participants
@Serhii1011010 @codecov-commenter @quarckster @joselsegura